Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snowflake-usage): do not ingest stage as a dataaset #4483

Merged
merged 1 commit into from
Mar 25, 2022
Merged

fix(snowflake-usage): do not ingest stage as a dataaset #4483

merged 1 commit into from
Mar 25, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@anshbansal anshbansal changed the title fix(snowflake-usage): do not ingest for stage as a dataaset fix(snowflake-usage): do not ingest stage as a dataaset Mar 24, 2022
@github-actions
Copy link

github-actions bot commented Mar 24, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files         5 suites   48m 31s ⏱️
   371 tests    371 ✔️   0 💤 0 ❌
1 702 runs  1 671 ✔️ 31 💤 0 ❌

Results for commit ca6bdc6.

♻️ This comment has been updated with latest results.

rslanka
rslanka approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   25m 25s ⏱️ + 11m 44s
674 tests ±0  615 ✔️ +1  59 💤 ±0  0 ❌  - 1 

Results for commit ca6bdc6. ± Comparison against base commit a1ebc6b.

@treff7es treff7es merged commit 7f1a1a3 into datahub-project:master Mar 25, 2022
@anshbansal anshbansal deleted the bugfix-snowflake-usage branch July 21, 2022 12:11
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
fix(snowflake-usage): do not ingest for stage as a dataaset (datahub-…
c0ce729 
…project#4483)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @rslanka @treff7es