Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): Change to forward slash-separated strings, as in the example #4528

Merged

Conversation

daha
Copy link
Contributor

@daha daha commented Mar 30, 2022

The doc was a bit confusing, mentioning "backslash-separated strings" when the example is using forward slash. The example seems correct to me so changing the description to use "forward slash".

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  93 files    93 suites   25m 52s ⏱️
680 tests 621 ✔️ 59 💤 0

Results for commit 20f48a2.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   57m 46s ⏱️
   388 tests    388 ✔️   0 💤 0
1 787 runs  1 749 ✔️ 38 💤 0

Results for commit 20f48a2.

Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabe-lyons gabe-lyons merged commit cd6a712 into datahub-project:master Mar 30, 2022
@daha daha deleted the forward-slash-separated-strings branch March 31, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants