Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup extra file #4541

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

anshbansal
Copy link
Collaborator

Seems #4456 added an extra file at root by mistake. Removing it.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  96 files  ±0    96 suites  ±0   18m 56s ⏱️ + 2m 40s
686 tests ±0  627 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit df90f53. ± Comparison against base commit a10a4ac.

@rslanka
Copy link
Contributor

rslanka commented Apr 4, 2022

Quick question @anshbansal: What is https://github.com/datahub-project/datahub/blob/master/metadata-ingestion/tests/integration/dbt/test_dbt.py#L166 doing? Is it because load_schemas is set to False via source_config_modifiers? There may be 3 more candidates in that case!

@rslanka rslanka self-assigned this Apr 4, 2022
@anshbansal
Copy link
Collaborator Author

I don't know @rslanka what that file is doing. I just saw this extra file at the root of the repository and don't think it should be here. As all tests pass this seems to be an extra file.

Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rslanka rslanka merged commit c30b473 into datahub-project:master Apr 5, 2022
@anshbansal anshbansal deleted the remove-extra-file branch April 5, 2022 15:28
aditya-radhakrishnan pushed a commit to aditya-radhakrishnan/datahub that referenced this pull request Apr 5, 2022
aditya-radhakrishnan pushed a commit to aditya-radhakrishnan/datahub that referenced this pull request Apr 5, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants