Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dependencies for usage sources #4561

Merged
merged 1 commit into from
Apr 1, 2022
Merged

fix: dependencies for usage sources #4561

merged 1 commit into from
Apr 1, 2022

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Apr 1, 2022 •
edited
Loading

#3782 introduced a regression due to missing dependencies

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.

rslanka
rslanka approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Apr 1, 2022 •
edited
Loading

Unit Test Results (build & test)

  96 files  ±0    96 suites  ±0   14m 3s ⏱️ - 11m 31s
686 tests ±0  627 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 32f706c. ± Comparison against base commit 2fc3a48.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 1, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   1h 1m 10s ⏱️ -26s
   393 tests ±0     393 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 809 runs  ±0  1 778 ✔️ ±0  31 💤 ±0  0 ❌ ±0 

Results for commit 32f706c. ± Comparison against base commit 2fc3a48.

♻️ This comment has been updated with latest results.

@rslanka rslanka merged commit 40188d2 into datahub-project:master Apr 1, 2022
@anshbansal anshbansal deleted the fix-dependencies branch April 4, 2022 09:49
@anshbansal anshbansal mentioned this pull request Apr 4, 2022
Merged
4 tasks
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
fix: dependencies for usage sources (datahub-project#4561)
c5901d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

@rslanka rslanka rslanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @pedro93 @rslanka