fix(bigquery): incorrect lineage when views are present #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rslanka
reviewed
Apr 4, 2022
| referenced_views = [ | ||
| BigQueryTableRef.from_string_name(spec) for spec in raw_ref_views | ||
| ] | ||
|
|
||
| try: | ||
| statementType = job["jobConfiguration"]["query"]["statementType"] |
There was a problem hiding this comment.
@treff7es / @anshbansal: Is this a bug? Should this instead be job["jobConfig"]["queryConfig"]["statementType"]?
There was a problem hiding this comment.
based on google's documentation I think you are right, it should be just configuration -> https://cloud.google.com/bigquery/docs/reference/rest/v2/Job
rslanka
reviewed
Apr 5, 2022
metadata-ingestion/src/datahub/ingestion/source/sql/bigquery.py
Outdated
Show resolved
Hide resolved
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
…ect#4568) * fix(bigquery): incorrect lineage when views are present Co-authored-by: Ravindra Lanka <rlanka@acryl.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist