fix(tableau): fix for incorrect schema returned by tableau api for sn… #4577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owflake connectionType
gabe-lyons
approved these changes
Apr 5, 2022
aditya-radhakrishnan
pushed a commit
to aditya-radhakrishnan/datahub
that referenced
this pull request
Apr 5, 2022
…owflake connectionType (datahub-project#4577)
aditya-radhakrishnan
pushed a commit
to aditya-radhakrishnan/datahub
that referenced
this pull request
Apr 5, 2022
…owflake connectionType (datahub-project#4577)
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
…owflake connectionType (datahub-project#4577)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…owflake connectionType
Along with this caveat mentioned in tableau document, it is observed that tableau metadata api returns incorrect schema for datasources querying tables across schemas.
This PR attempts to fix incorrect schema scenario for all connectionTypes by extracting schema from fully qualified name of table wherever possible.
Checklist