Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metadata-service): Supporting a configurable Authorizer Chain #4584

Merged
merged 9 commits into from
Apr 7, 2022

Conversation

jjoyce0510
Copy link
Collaborator

Summary

In this PR, we introduce support for a configurable Authorizer chain in the metadata service. This allows people to write their own implementation of the Authorizer interface and plug it in so that requests to perform specific actions can be authorized on DataHub using custom approaches.

Changes

  • Adding a custom AuthorizerChain component, which internally nests the default DataHub Authorizer as a fixed Authorizer.
  • Supporting configuration of custom Authorizer components inside of application.yml

Status
WIP

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.

Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just minor comments

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Unit Test Results (build & test)

  96 files  +1    96 suites  +1   13m 14s ⏱️ - 1m 54s
687 tests +6  628 ✔️ +7  59 💤 ±0  0  - 1 

Results for commit dccc008. ± Comparison against base commit fe5f24c.

♻️ This comment has been updated with latest results.

@jjoyce0510 jjoyce0510 merged commit 7080798 into datahub-project:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants