Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingestion): Redshift Usage Source - simplify OperationalStats workunit generation. #4585

Merged
merged 4 commits into from
Apr 7, 2022
Merged

feat(ingestion): Redshift Usage Source - simplify OperationalStats workunit generation. #4585

merged 4 commits into from
Apr 7, 2022

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Apr 5, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.

@github-actions
Copy link

github-actions bot commented Apr 5, 2022 •
edited
Loading

Unit Test Results (build & test)

  95 files   - 1    95 suites   - 1   9m 55s ⏱️ - 8m 40s
681 tests  - 6  620 ✔️  - 8  59 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 7a10d43. ± Comparison against base commit bc1c060.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   58m 6s ⏱️
   394 tests    394 ✔️   0 💤 0 ❌
1 814 runs  1 776 ✔️ 38 💤 0 ❌

Results for commit 7a10d43.

aditya-radhakrishnan
aditya-radhakrishnan approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for simplifying this.

treff7es
treff7es approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rslanka rslanka merged commit 5e25cd1 into datahub-project:master Apr 7, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@rslanka @maggiehays
feat(ingestion): Redshift Usage Source - simplify OperationalStats wo…
69903ea 
…rkunit generation. (datahub-project#4585)

* feat(ingestion): Redshift Usage Source - simplify OperationalStats workunit generation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

Assignees

@treff7es treff7es

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rslanka @treff7es @aditya-radhakrishnan