Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest) bigquery: Moving bigquery temporary credential deletion to atexit #4701

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

treff7es
Copy link
Contributor

Moving bigquery temporary credential deletion to atexit vs del because it is more reliable and deterministic.
Recently with del it threw an error because the logging object was None as it seemed to be cleaned up when the method was called.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

…cause it is more reliable and deterministic.
@github-actions
Copy link

github-actions bot commented Apr 20, 2022

Unit Test Results (build & test)

  97 files  ±0    97 suites  ±0   17m 25s ⏱️ - 2m 47s
701 tests ±0  642 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 5259b17. ± Comparison against base commit f659cc8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 20, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   1h 3m 58s ⏱️
   431 tests    431 ✔️   0 💤 0
2 080 runs  2 014 ✔️ 66 💤 0

Results for commit 5259b17.

♻️ This comment has been updated with latest results.

@treff7es treff7es changed the title Moving bigquery temporary credential deletion to atexit fix(ingest) bigquery: Moving bigquery temporary credential deletion to atexit Apr 20, 2022
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rslanka rslanka merged commit bb2b851 into datahub-project:master Apr 20, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants