Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery): error due to not handling data properly #4702

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

@anshbansal anshbansal changed the title fix(bigquery): error due to not handling date properly fix(bigquery): error due to not handling data properly Apr 20, 2022
@github-actions
Copy link

Unit Test Results (build & test)

  97 files  ±0    97 suites  ±0   28m 55s ⏱️ + 8m 43s
701 tests ±0  642 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit bbea594. ± Comparison against base commit f659cc8.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   58m 36s ⏱️
   431 tests    431 ✔️   0 💤 0
2 080 runs  2 014 ✔️ 66 💤 0

Results for commit bbea594.

Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sql_query = re.sub(
r"(\bdate\b)", rf"{self._DATE_SWAP_TOKEN}", sql_query, flags=re.IGNORECASE
)
self.token_to_original: Dict[str, str] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for making it generic

@treff7es treff7es merged commit 4b7f407 into datahub-project:master Apr 20, 2022
@anshbansal anshbansal deleted the fix-bigquery-bugs branch April 20, 2022 16:15
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lineage, BigQuery - usage of word "data" as a CTE token breaks metadata ingestion
2 participants