Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datahub-client): add java kafka emitter #5074

Merged

Conversation

MugdhaHardikar-GSLab
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Unit Test Results (build & test)

385 tests  +3   385 ✔️ +3   10m 7s ⏱️ +50s
  91 suites +2       0 💤 ±0 
  91 files   +2       0 ±0 

Results for commit 3d5e1d2. ± Comparison against base commit 0ee2569.

♻️ This comment has been updated with latest results.

@@ -0,0 +1,164 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pins us to a particular model from the MetadataChangeProposal instead of using the generated one. Was there no other way to get the CI passing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is just placeholder. It will get replaced by latest avsc during jar build.

@ercsonusharma
Copy link

Is it intended not to have emit(List<UpsertAspectRequest> request, Callback callback) method for KafkaEmitter similar to the RestEmitter? Having that will make it compatible with existing codebase and need not to migrate to emit(MetadataChangeProposalWrapper mcpw, Callback callback) - Any thoughts?

@RyanHolstien
Copy link
Collaborator

RyanHolstien commented Jun 15, 2022

Is it intended not to have emit(List<UpsertAspectRequest> request, Callback callback) method for KafkaEmitter similar to the RestEmitter? Having that will make it compatible with existing codebase and need not to migrate to emit(MetadataChangeProposalWrapper mcpw, Callback callback) - Any thoughts?

The UpsertAspectRequest object uses the OpenAPI compatible models rather than the Avro compatible models so I don't think it makes sense to support it. Would require converting back from the OpenAPI models to Avro.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes

build.gradle Outdated Show resolved Hide resolved
metadata-integration/java/datahub-client/build.gradle Outdated Show resolved Hide resolved
metadata-integration/java/as-a-library.md Outdated Show resolved Hide resolved
metadata-integration/java/datahub-client/build.gradle Outdated Show resolved Hide resolved
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 8358ea8 into datahub-project:master Jun 21, 2022
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Jun 22, 2022
alexey-kravtsov pushed a commit to infobip/datahub that referenced this pull request Jul 8, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants