-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datahub-client): add java kafka emitter #5074
feat(datahub-client): add java kafka emitter #5074
Conversation
@@ -0,0 +1,164 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pins us to a particular model from the MetadataChangeProposal instead of using the generated one. Was there no other way to get the CI passing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is just placeholder. It will get replaced by latest avsc during jar build.
Is it intended not to have |
The UpsertAspectRequest object uses the OpenAPI compatible models rather than the Avro compatible models so I don't think it makes sense to support it. Would require converting back from the OpenAPI models to Avro. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes
metadata-integration/java/datahub-client/src/main/java/datahub/client/kafka/KafkaEmitter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist