refactor(ui): UI Navigation Refactoring #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscollins3456
approved these changes
Jun 2, 2022
| }} | ||
| /> | ||
| </Tooltip> | ||
| <CopyUrn urn={urn} isActive={copiedUrn} onClick={() => setCopiedUrn(true)} /> |
jjoyce0510
changed the title
chriscollins3456
approved these changes
Jun 3, 2022
| /** | ||
| * URL Paths for each settings page. | ||
| */ | ||
| const PATHS = [ |
There was a problem hiding this comment.
maybe SETTINGS_PATHS? was confused below when you were mapping over "PATHS"
| <Redirect to={`${pathname}${pathname.endsWith('/') ? '' : '/'}${DEFAULT_PATH.path}`} /> | ||
| </Route> | ||
| {PATHS.map((p) => ( | ||
| <Route path={`${path}/${p.path.replace('/', '')}`} render={() => p.content} key={p.path} /> |
There was a problem hiding this comment.
why do you have this replace logic here if there's no "/" in any of the paths above?
5 tasks
|
When will this pr be merged and released? |
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, 2 important things are happening:
We are super excited about these changes, they will clear the runway for more functionality and improve the organization of the app significantly. See the changes in the screenshots below.
Changes
Screenshots
Checklist