Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Kafka-setup): Make sure it doesn't fail when the new envs are not set #5168

Merged
merged 2 commits into from
Jun 14, 2022
Merged

fix(Kafka-setup): Make sure it doesn't fail when the new envs are not set #5168

merged 2 commits into from
Jun 14, 2022

Conversation

dexter-mh-lee
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@dexter-mh-lee dexter-mh-lee merged commit 93145d1 into datahub-project:master Jun 14, 2022
@dexter-mh-lee dexter-mh-lee deleted the dl--kafka-setup-env branch June 14, 2022 17:29
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@maggiehays
fix(Kafka-setup): Make sure it doesn't fail when the new envs are not…
bbb2b8f 
… set (datahub-project#5168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dexter-mh-lee @pedro93 @jjoyce0510