refactor(configs): Simplify Kafka Topic name configurations + docs #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figs' into jj--simplify-kafka-topic-name-configs
…figs' into jj--simplify-kafka-topic-name-configs
anshbansal
previously requested changes
Jun 17, 2022
|
@anshbansal These are not just being deprecated now, these topics have been deprecated for some time. Regardless calling these env vars specifically as deprecated (not topics themselves) |
…figs' into jj--simplify-kafka-topic-name-configs
dexter-mh-lee
approved these changes
Jun 17, 2022
alexey-kravtsov
pushed a commit
to infobip/datahub
that referenced
this pull request
Jul 8, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify the environment variables for MAE / MCE consumer topic names for the deprecated legacy topics: MetadataChangeEvent, MetadataAuditEvent, FailedMetadataChangeEvent.
Previously, env variables were named inconsistently between GMS and the consumers.
Changes
datahub-mae-consumer: KAFKA_TOPIC_NAME --> METADATA_AUDIT_EVENT_NAME
datahub-mce-consumer: KAFKA_MCE_TOPIC_NAME --> METADATA_CHANGE_EVENT_NAME
These changes are backward compatible, so using the previous configuration values OR the new values will work.
Also updated + improved Kafka documentation to reflect these changes.
Checklist