Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add base image for ingest #5243

Merged

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal marked this pull request as ready for review June 24, 2022 16:51
@github-actions
Copy link

Unit Test Results (build & test)

389 tests  ±0   389 ✔️ ±0   10m 30s ⏱️ -17s
  92 suites ±0       0 💤 ±0 
  92 files   ±0       0 ±0 

Results for commit 4e7a9ed. ± Comparison against base commit 4b3135a.

Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comment about how to maintain this file

@@ -0,0 +1,313 @@
absl-py==1.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you geneated this file?
What should be the process to regenerate this file if somebody adds/pins a new/existing dep in ingestion?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a pip freeze in #5225 to get list of dependencies. If the build time starts to become large again then we can take the freeze from that and update this file.

@anshbansal anshbansal merged commit 60ca958 into datahub-project:master Jun 27, 2022
@anshbansal anshbansal deleted the add-base-image-ingestion branch June 27, 2022 08:38
alexey-kravtsov pushed a commit to infobip/datahub that referenced this pull request Jul 8, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants