feat(ingestion) Implement secrets in new managed ingestion form #5574
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import React, { useState } from 'react'; | ||
| import { Button, message } from 'antd'; | ||
| import { PlusOutlined } from '@ant-design/icons'; | ||
| import { blue } from '@ant-design/colors'; | ||
| import styled from 'styled-components/macro'; | ||
| import { SecretBuilderModal } from '../../../../secret/SecretBuilderModal'; | ||
| import { useCreateSecretMutation } from '../../../../../../graphql/ingestion.generated'; | ||
| import { SecretBuilderState } from '../../../../secret/types'; | ||
|
|
||
| const CreateButton = styled(Button)` | ||
| align-items: center; | ||
| display: flex; | ||
| justify-content: center; | ||
| margin: 8px 12px 4px 12px; | ||
| width: calc(100% - 24px); | ||
|
|
||
| &:hover { | ||
| color: ${blue[5]}; | ||
| } | ||
|
|
||
| .anticon-plus { | ||
| margin-right: 5px; | ||
| } | ||
| `; | ||
|
|
||
| interface Props { | ||
| refetchSecrets: () => void; | ||
| } | ||
|
|
||
| function CreateSecretButton({ refetchSecrets }: Props) { | ||
| const [isCreateModalVisible, setIsCreateModalVisible] = useState(false); | ||
| const [createSecretMutation] = useCreateSecretMutation(); | ||
|
|
||
| const createSecret = (state: SecretBuilderState, resetBuilderState: () => void) => { | ||
| createSecretMutation({ | ||
| variables: { | ||
| input: { | ||
| name: state.name as string, | ||
| value: state.value as string, | ||
| description: state.description as string, | ||
| }, | ||
| }, | ||
| }) | ||
| .then(() => { | ||
| setIsCreateModalVisible(false); | ||
| resetBuilderState(); | ||
| setTimeout(() => refetchSecrets(), 3000); | ||
| message.loading({ content: `Loading...`, duration: 3 }).then(() => { | ||
| message.success({ content: `Successfully created Secret!` }); | ||
| }); | ||
| }) | ||
| .catch((e) => { | ||
| message.destroy(); | ||
| message.error({ content: `Failed to create secret: \n ${e.message || ''}` }); | ||
| }); | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| <CreateButton onClick={() => setIsCreateModalVisible(true)} type="text"> | ||
| <PlusOutlined /> Create Secret | ||
| </CreateButton> | ||
| {isCreateModalVisible && ( | ||
| <SecretBuilderModal | ||
| visible={isCreateModalVisible} | ||
| onCancel={() => setIsCreateModalVisible(false)} | ||
| onSubmit={createSecret} | ||
| /> | ||
| )} | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| export default CreateSecretButton; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import React from 'react'; | ||
| import { Divider, Form, Select } from 'antd'; | ||
| import styled from 'styled-components/macro'; | ||
| import { RecipeField } from '../utils'; | ||
| import { Secret } from '../../../../../../types.generated'; | ||
| import CreateSecretButton from './CreateSecretButton'; | ||
|
|
||
| const StyledDivider = styled(Divider)` | ||
| margin: 0; | ||
| `; | ||
|
|
||
| interface SecretFieldProps { | ||
| field: RecipeField; | ||
| secrets: Secret[]; | ||
| refetchSecrets: () => void; | ||
| } | ||
|
|
||
| function SecretField({ field, secrets, refetchSecrets }: SecretFieldProps) { | ||
| return ( | ||
| <Form.Item name={field.name} label={field.label} tooltip={field.tooltip}> | ||
| <Select | ||
| showSearch | ||
| filterOption={(input, option) => !!option?.children.toLowerCase().includes(input.toLowerCase())} | ||
| dropdownRender={(menu) => ( | ||
| <> | ||
| {menu} | ||
| <StyledDivider /> | ||
| <CreateSecretButton refetchSecrets={refetchSecrets} /> | ||
| </> | ||
| )} | ||
| > | ||
| {secrets.map((secret) => ( | ||
| <Select.Option key={secret.urn} value={`\${${secret.name}}`}> | ||
|
There was a problem hiding this comment. gotta escape the |
||
| {secret.name} | ||
| </Select.Option> | ||
| ))} | ||
| </Select> | ||
| </Form.Item> | ||
| ); | ||
| } | ||
|
|
||
| export default SecretField; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we store these as constant and constant+1 so if one is changed this modal doesn't disappear for (seemingly) no reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh i wanted to do that, but it's Ant designs constant of 1050 so we don't actually have access to that in our code base :( so this is risky if they change that number for some reason. we could just plop this at some ridiculously high number as well if we really wanted to