Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) Fix duplicate schema field rendering with siblings #7057

Conversation

chriscollins3456
Copy link
Collaborator

We had an issue reported by several users where scrolling on their schema caused the same field to be repeated and take over the whole schema. This was happening because the key of one (or more) the schema rows had a duplicate, causing bad rendering issues and duplicating the same rows.

This could happen when two siblings had different schemas. If one of the schemas had an extra row or two inserted in the middle, the two schemas would be merged by index and therefore we would produce duplicate fields, causing duplicate rows, breaking the schema renderer.

This fixes the issue by merging based on the fieldPath instead, so now we get a combined schema of the siblings with unique field paths, preventing duplicated.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 17, 2023
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chriscollins3456 chriscollins3456 merged commit a3c0bb2 into datahub-project:master Jan 18, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants