Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/bigquery): Usage rate limiting and lineage exported log fix #7297

Merged
merged 2 commits into from
Feb 10, 2023
Merged

fix(ingest/bigquery): Usage rate limiting and lineage exported log fix #7297

merged 2 commits into from
Feb 10, 2023

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Feb 9, 2023

  • Fix for BigQuery usage extraction rate limiting
  • Fix for BigQuery lineage extraction when audit logs exported

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es
- Fix for bigquery usage rate limiting
cf29b01 
- Fix for bigquery lineage extraction when audit logs exported
@treff7es
Reverting accidentaly added filter
bb577cd
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 9, 2023
aditya-radhakrishnan
aditya-radhakrishnan approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Are there any tests we can add here?

@anshbansal anshbansal merged commit 97355bc into datahub-project:master Feb 10, 2023
@anshbansal
Copy link
Collaborator

Rate limiting is not something that can be tested via unit tests. So merging.

oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@treff7es
fix(ingest/bigquery): Usage rate limiting and lineage exported log fix (
bce3f92 
datahub-project#7297)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treff7es @anshbansal @aditya-radhakrishnan