Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(github): change github reference to git references #7308

Merged
merged 2 commits into from
Feb 10, 2023
Merged

refactor(github): change github reference to git references #7308

merged 2 commits into from
Feb 10, 2023

Conversation

anshbansal
Copy link
Collaborator

Will wait until tests pass and then mark as ready for review.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 10, 2023
@anshbansal anshbansal marked this pull request as ready for review February 10, 2023 12:20
hsheth2
hsheth2 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal merged commit ca65f9d into master Feb 10, 2023
@anshbansal anshbansal deleted the aseem-github-ref-update branch February 10, 2023 15:37
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@anshbansal
refactor(github): change github reference to git references (datahub-…
d85b2ac 
…project#7308)
@danielcmessias danielcmessias mentioned this pull request Dec 18, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @hsheth2