perf(ingest): speed up MCPW.validate() #7319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my local tests with an MCPW with a dataset schema of 3000 columns, this reduced runtime from ~676 ms to ~189 ms, which is a 3-4x improvement. It seems to scale linearly with the size of the MCPW object, but I didn't test that extensively. Note that almost 200ms is still pretty bad for basic data validation. With the changes from acryldata/avro_gen#18, I was able to get it down to ~130 ms.
github-actions
bot
added
the
ingestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my local tests with an MCPW with a dataset schema of 3000 columns, this reduced runtime from ~676 ms to ~189 ms, which is a 3-4x improvement. It seems to scale linearly with the size of the MCPW object, but I didn't test that extensively.
Note that almost 200ms is still pretty bad for basic data validation. With the changes from acryldata/avro_gen#18, I was able to get it down to ~130 ms. Not sure how much further it is worth pushing it.
Checklist