fix(ui) Fix 404 page routing bug #7824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
approved these changes
Apr 14, 2023
yoonhyejin
pushed a commit
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a routing bug in the app right now where if a user goes to a route that doesn't exist, instead of showing them our 404 page, we show them an empty business glossary page. This is because routes were getting caught in the
GlossaryRoutescomponent and never making it past it to show theNoPageFoundcomponent.This PR fixes that by adding a real route that anything that starts with
glossarywill render theGlossaryRoutescomponent. So now a broken link will actually render our 404 page.Checklist