Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(platform): Refactoring ES Utils, adding EXISTS condition support to Filter Criterion #7832

Merged

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Apr 17, 2023

Summary

In this PR, we support a new filter condition inside Criterion.pdl for checking whether a field EXISTS in elasticsearch. We also add some unit tests to ESUtils.java and refactor to place private methods below public ones.

Change summary

  1. Refactor ESUtils.java for readability
  2. Support EXISTS operation inside Condition.pdl
  3. Add unit tests to confirm that ES Filters are consistently constructed as expected in various cases

Why make this change? This unlocks the ability to easily support EXISTS style filters from the UI and elsewhere against particular index fields.

Status

Ready for review

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Apr 17, 2023
@jjoyce0510 jjoyce0510 merged commit 73a1237 into datahub-project:master Apr 20, 2023
iprentic pushed a commit that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants