Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): fix minor bug + protective dep requirements #7861

Merged
merged 2 commits into from
Apr 25, 2023
Merged

fix(ingest): fix minor bug + protective dep requirements #7861

merged 2 commits into from
Apr 25, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Apr 20, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Apr 20, 2023
@asikowitz
Copy link
Collaborator

Lint failures but LGTM

@hsheth2 hsheth2 merged commit 29e5cfd into datahub-project:master Apr 25, 2023
@hsheth2 hsheth2 deleted the protective-dep branch April 25, 2023 21:35
iprentic pushed a commit that referenced this pull request Apr 27, 2023
@hsheth2
fix(ingest): fix minor bug + protective dep requirements (#7861)
db3c804
hsheth2 added a commit to acryldata/dbt-impact-action that referenced this pull request Jul 5, 2023
@hsheth2
update acryl-datahub version
38b2bcc 
This includes datahub-project/datahub#7861,
which fixes this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @asikowitz