Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add GCS ingestion source #7903

Merged
merged 6 commits into from
Apr 27, 2023
Merged

feat(ingest): add GCS ingestion source #7903

merged 6 commits into from
Apr 27, 2023

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Apr 25, 2023 •
edited
Loading

https://feature-requests.datahubproject.io/p/source-connector-for-google-cloud-storage

Screenshot from 2023-04-27 15-12-47
Screenshot from 2023-04-27 15-14-12
Screenshot from 2023-04-27 15-15-25

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Apr 25, 2023
@mayurinehate mayurinehate marked this pull request as ready for review April 26, 2023 09:45
treff7es
treff7es approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and works, thanks!

metadata-ingestion/src/datahub/ingestion/source/gcs/gcs_utils.py


def get_gcs_bucket_name(path):
if not is_gcs_uri(path):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess currently this never can happen as there is another check where you call it.

metadata-ingestion/src/datahub/ingestion/source/data_lake_common/data_lake_utils.py
instance=self.instance,
backcompat_instance_for_guid=self.env,
bucket_name=name,
)

def get_bucket_name(self, path):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this don't have to be two separate method as it only differs from the prefix

@treff7es treff7es merged commit a0c4e0d into datahub-project:master Apr 27, 2023
iprentic pushed a commit that referenced this pull request Apr 27, 2023
@mayurinehate @treff7es
feat(ingest): add GCS ingestion source (#7903)
c21ad02 
Co-authored-by: Tamas Nemeth <treff7es@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

@shirshanka shirshanka Awaiting requested review from shirshanka

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @treff7es