Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(airflow): respect port parameter if provided #7945

Merged
merged 1 commit into from
May 2, 2023
Merged

feat(airflow): respect port parameter if provided #7945

merged 1 commit into from
May 2, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented May 2, 2023

Slack ref: https://datahubspace.slack.com/archives/CUMUWQU66/p1682106348136369

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 2, 2023
asikowitz
asikowitz approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested with port not provided? I couldn't tell from a glance at the code if port has a default

@hsheth2
Copy link
Collaborator Author

hsheth2 commented May 2, 2023

@asikowitz yup the current behavior works when port is not present (you previously just stuffed it into the host parameter). This PR is adding support for the port field.

@hsheth2 hsheth2 merged commit 6833494 into datahub-project:master May 2, 2023
@hsheth2 hsheth2 deleted the airflow-port-hook branch May 2, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @asikowitz