feat(ingest): add more fail-safes to stateful ingestion #8111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
Stacked on top of the changes in datahub-project#8104. Review that PR first.
hsheth2
force-pushed
the
stateful-fail-safe
branch
from
ac071e1
to
ff4bad3
Compare
asikowitz
approved these changes
May 25, 2023
| self.job_id, self.state_type_class | ||
| ) | ||
| if not last_checkpoint: | ||
| return | ||
| cur_checkpoint = self.state_provider.get_current_checkpoint(self.job_id) | ||
| assert cur_checkpoint is not None | ||
| # Get the underlying states | ||
| last_checkpoint_state = cast(GenericCheckpointState, last_checkpoint.state) | ||
| last_checkpoint_state: GenericCheckpointState = last_checkpoint.state | ||
| cur_checkpoint_state = cast(GenericCheckpointState, cur_checkpoint.state) |
There was a problem hiding this comment.
Can you remove the cast here too?
There was a problem hiding this comment.
nope - get_current_checkpoint doesn't infer types in the same way
|
|
||
| # If the source already had a failure, skip soft-deletion. | ||
| # TODO: Eventually, switch this to check if anything in the pipeline had a failure so far. | ||
| if self.source.get_report().failures: |
There was a problem hiding this comment.
Does this take into account the commit_policy? Or for stale entity removal the rule is just commit iff there are no failures
There was a problem hiding this comment.
the latter
in the commit policy rules should be tied to each stateful ingestion handler
There was a problem hiding this comment.
Does that mean we're dropping support for a configurable commit policy? Right now it seems like it doesn't really do anything
There was a problem hiding this comment.
eventually yes I'd like to drop support for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of the changes in #8104. Review that PR first.
Checklist