Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/kafka): Better error handling around topic and topic description extraction #8183

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix(ingest/kafka): Better error handling around topic and topic description extraction #8183

merged 1 commit into from
Jun 7, 2023

Conversation

asikowitz
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 7, 2023
hsheth2
hsheth2 approved these changes Jun 7, 2023
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/kafka.py
)
except Exception as e:
logger.warning(f"Failed to extract topic {t}", exc_info=True)
self.report.report_warning(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a failure?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk about this source at all, so I erred on the side of caution lol. I am happy to swap if you think it should be

@asikowitz asikowitz merged commit fd790e3 into datahub-project:master Jun 7, 2023
@asikowitz asikowitz deleted the kafka-robustness branch June 7, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@treff7es treff7es Awaiting requested review from treff7es

@mayurinehate mayurinehate Awaiting requested review from mayurinehate

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asikowitz @hsheth2