Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ownership): Corrects graphQL resolver for entity operations #8219

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Jun 12, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jun 12, 2023
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! curious about one of the changes when it looks like the only necessary change is the check in OwnerUpdateMapper.java

Comment on lines -303 to -304
public static String mapOwnershipTypeToEntity(OwnershipType type) {
final String typeName = SYSTEM_ID + type.name().toLowerCase();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why make this change here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because OwnershipType is a graphQL generated class. Wanted to use the same method for the PDL-generated equivalent class, as that is what was being used in the OwnerUpdateMapper.java file.

@pedro93 pedro93 merged commit 460f96d into datahub-project:master Jun 13, 2023
@pedro93 pedro93 deleted the ps-fix-ownership-resolvers branch June 13, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants