Fix flaky add_user smoke test #8471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Jul 20, 2023
| @@ -20,7 +20,7 @@ describe("add_user", () => { | |||
| cy.visit("/settings/identities/users"); | |||
| cy.waitTextVisible("Invite Users"); | |||
|
|
|||
| cy.clickOptionWithText("Invite Users") | |||
| cy.clickOptionWithText("Invite Users").wait(1000); | |||
There was a problem hiding this comment.
Any chance we should wait until the URL matches a particular REGEX?
Or is it re-generating a token so we cannot use a regex match here?
There was a problem hiding this comment.
yeah, it re-generating a token every time, maybe we can check for length of token in REGEX...
There was a problem hiding this comment.
Tested this REGEX locally and it works.
"/signup?invite_token=\w{32}/"
jjoyce0510
reviewed
Jul 25, 2023
|
|
||
| cy.waitTextVisible(/signup\?invite_token=\w+/).then(($elem) => { | ||
| cy.waitTextVisible(/signup\?invite_token=\w{32}/).then(($elem) => { |
There was a problem hiding this comment.
nice!! thanks for adding the regex matching. this is much better
jjoyce0510
approved these changes
Jul 25, 2023
jjoyce0510
approved these changes
Aug 2, 2023
yoonhyejin
pushed a commit
that referenced
this pull request
Aug 24, 2023
Co-authored-by: John Joyce <john@acryl.io> Co-authored-by: Aseem Bansal <asmbansal2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main source of add_user being flaky is the behavior of 'Share Invite Link' modal on settings/identities/users.
Sometimes it takes some time to present actual token id on UI while token url is already present.
So Cypress verifies that URL present and goes forward causing it to copy corrupted URL of token
This causes test to fail later.
This is how UI looks when this happens:
The solution for this would be to wait for 1000ms after 'Share Invite Link' is open to make sure that full invite link is present.
Linear ticket: https://linear.app/acryl-data/issue/OBS-47/qa-fix-add-user-flaky-test
Checklist