Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datahub-gms) usage stats queryRange API's Authorization error for Dataset Owners #8819

Merged
merged 7 commits into from
Sep 20, 2023
Merged

fix(datahub-gms) usage stats queryRange API's Authorization error for Dataset Owners #8819

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4efd371
fix UsageStats queryRange API's Authorization error
Sep 11, 2023
18061ae
fix checkstyle
Sep 11, 2023
7ae2a56
Merge branch 'master' into fix-usage-queryRange-authorization-error
siladitya2 Sep 11, 2023
026622b
Merge branch 'master' into fix-usage-queryRange-authorization-error
siladitya2 Sep 12, 2023
9817014
Merge branch 'master' into fix-usage-queryRange-authorization-error
siladitya2 Sep 12, 2023
68ad7b8
Merge branch 'master' into fix-usage-queryRange-authorization-error
siladitya2 Sep 13, 2023
ae2037f
Merge branch 'master' into fix-usage-queryRange-authorization-error
siladitya2 Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...e/restli-servlet-impl/src/main/java/com/linkedin/metadata/resources/usage/UsageStats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,10 @@ public Task<UsageQueryResult> query(@ActionParam(PARAM_RESOURCE) @Nonnull String
public Task<UsageQueryResult> queryRange(@ActionParam(PARAM_RESOURCE) @Nonnull String resource,
@ActionParam(PARAM_DURATION) @Nonnull WindowDuration duration, @ActionParam(PARAM_RANGE) UsageTimeRange range) {
Authentication auth = AuthenticationContext.getAuthentication();
Urn resourceUrn = UrnUtils.getUrn(resource);
if (Boolean.parseBoolean(System.getenv(REST_API_AUTHORIZATION_ENABLED_ENV))
&& !isAuthorized(auth, _authorizer, ImmutableList.of(PoliciesConfig.VIEW_DATASET_USAGE_PRIVILEGE), (ResourceSpec) null)) {
&& !isAuthorized(auth, _authorizer, ImmutableList.of(PoliciesConfig.VIEW_DATASET_USAGE_PRIVILEGE),
new ResourceSpec(resourceUrn.getEntityType(), resourceUrn.toString()))) {
throw new RestLiServiceException(HttpStatus.S_401_UNAUTHORIZED,
"User is unauthorized to query usage.");
}
Expand Down
Loading