Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for edit_documentation and glossary_navigation cypress tests #8838

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Fix for edit_documentation and glossary_navigation cypress tests #8838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
767f9ff
Fix for edit_documentation test
kkorchak Sep 13, 2023
d3c50f8
Fix for glossary_navigation test
kkorchak Sep 13, 2023
2ed69a1
Merge branch 'master' into origin/FixesForIntermittentlyFailingCypres…
kkorchak Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions smoke-test/tests/cypress/cypress/e2e/glossary/glossary_navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ describe("glossary sidebar navigation test", () => {
//ensure the new term is under the parent term group in the navigation sidebar
cy.get('*[class^="GlossaryBrowser"]').contains(glossaryTermGroup).click();
cy.get('*[class^="GlossaryEntitiesList"]').contains(glossaryTerm).should("be.visible");
cy.get('*[class^="GlossaryBrowser"] [aria-label="down"]').click().wait(1000);
cy.get('*[class^="GlossaryBrowser"]').contains(glossaryTerm).should("not.exist");
//move a term group from the root level to be under a parent term group
cy.goToGlossaryList();
cy.clickOptionWithText(glossaryTermGroup);
Expand All @@ -41,8 +39,8 @@ describe("glossary sidebar navigation test", () => {
cy.get("button").contains("Move").click();
cy.waitTextVisible("Moved Term Group!");
//ensure it is no longer on the sidebar navigator at the top level but shows up under the new parent
cy.get('*[class^="GlossaryBrowser"] [aria-label="down"]').click().wait(1000);
cy.get('*[class^="GlossaryBrowser"]').contains(glossaryTermGroup).should("not.exist");
cy.get('*[class^="GlossaryBrowser"]').contains(glossaryParentGroup).click();
cy.get('*[class^="GlossaryEntitiesList"]').contains(glossaryTermGroup).should("be.visible");
//delete a term group
cy.goToGlossaryList();
cy.clickOptionWithText(glossaryParentGroup);
Expand Down
13 changes: 7 additions & 6 deletions smoke-test/tests/cypress/cypress/e2e/mutations/edit_documentation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ describe("edit documentation and link to dataset", () => {
cy.contains("Sample doc").trigger("mouseover", { force: true });
cy.get('[data-icon="delete"]').click();
cy.waitTextVisible("Link Removed");
cy.get("button").contains("Add Link").click();
cy.get("#addLinkForm_url").type(wrong_url);
cy.get("button").contains("Add Link").click().wait(1000);
cy.get('[role="dialog"] #addLinkForm_url').type(wrong_url);
cy.waitTextVisible("This field must be a valid url.");
cy.focused().clear();
cy.waitTextVisible("A URL is required.");
Expand All @@ -54,9 +54,9 @@ describe("edit documentation and link to dataset", () => {
it("open test domain page, remove and add dataset link", () => {
cy.loginWithCredentials();
cy.visit("/domain/urn:li:domain:marketing/Entities");
cy.get("[role='tab']").contains("Documentation").click();
cy.get("button").contains("Add Link").click();
cy.get("#addLinkForm_url").type(wrong_url);
cy.waitTextVisible("SampleCypressKafkaDataset");
cy.get("button").contains("Add Link").click().wait(1000);
cy.get('[role="dialog"] #addLinkForm_url').type(wrong_url);
cy.waitTextVisible("This field must be a valid url.");
cy.focused().clear();
cy.waitTextVisible("A URL is required.");
Expand All @@ -66,6 +66,7 @@ describe("edit documentation and link to dataset", () => {
cy.get('[role="dialog"] button').contains("Add").click();
cy.waitTextVisible("Link Added");
cy.get("[role='tab']").contains("Documentation").click();
cy.waitTextVisible("Edit");
cy.get(`[href='${correct_url}']`).should("be.visible");
cy.contains("Sample doc").trigger("mouseover", { force: true });
cy.get('[data-icon="delete"]').click();
Expand Down Expand Up @@ -94,4 +95,4 @@ describe("edit documentation and link to dataset", () => {
cy.waitTextVisible("Foo field description has changed");
cy.waitTextVisible("(edited)");
});
});
});
Loading