fix(frontend): update cookie module #8862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanHolstien
added
bug
pedro93
reviewed
Sep 19, 2023
pedro93
reviewed
Sep 19, 2023
| HttpServletResponse servletResponse = mock(HttpServletResponse.class); | ||
| FilterChain filterChain = mock(FilterChain.class); | ||
| Actor actor = new Actor(ActorType.USER, "datahub"); | ||
| // String token = _statefulTokenService.generateAccessToken(TokenType.SESSION, actor, 0L, System.currentTimeMillis(), "token", |
There was a problem hiding this comment.
Why is this commented out? If it's not used might as well delete.
Is there no need to test the stateful token service?
There was a problem hiding this comment.
This shows how the token was generated, I left in to make it more obvious
There was a problem hiding this comment.
It's not super intuitive to know how the token is generated otherwise so I'd prefer to leave it in for anyone who wants to make a similar test and looks through this file if it doesn't bother you too much :)
github-actions
bot
added
docs
david-leifker
approved these changes
Sep 20, 2023
|
Still has some checkstyle issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a breaking change for the session cookies. All previously created session cookies will be invalid regardless of their expiration time and users will have to login again. There should be no other issues with this change.
Updates session cookie configuration to utilize better security practices.
Checklist