fix(ingest/bigquery): show report in output #8867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
mayurinehate
requested changes
Sep 22, 2023
There was a problem hiding this comment.
Oops. Thanks for catching this. This did work earlier when using inheritance, and stopped working after refractoring to use composition.
I quickly tried these changes and it still didn't work on my machine. Only printed empty objects
'schema_api_perf': {},
'audit_log_api_perf': {},
With suggested changes, it works as expected.
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_report.py
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_report.py
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_report.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_report.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_report.py
Outdated
Show resolved
Hide resolved
…gquery_report.py Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com>
…gquery_report.py Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com>
…gquery_report.py Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com>
…gquery_report.py Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com>
…gquery_report.py Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com>
|
@mayurinehate thanks - made those changes |
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_report.py
Outdated
Show resolved
Hide resolved
…gquery_report.py Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com>
asikowitz
approved these changes
Sep 22, 2023
asikowitz
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #8626.
The report currently shows the object refs:
Checklist