feat(ui) Make certain things disabled if read only mode is enabled #8870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
approved these changes
Sep 20, 2023
jjoyce0510
reviewed
Sep 20, 2023
| @@ -89,12 +89,13 @@ export const SettingsPage = () => { | |||
| const isPoliciesEnabled = config?.policiesConfig.enabled; | |||
| const isIdentityManagementEnabled = config?.identityManagementConfig.enabled; | |||
| const isViewsEnabled = config?.viewsConfig.enabled; | |||
| const { readOnlyModeEnabled } = config.featureFlags; | |||
|
|
|||
| const showPolicies = (isPoliciesEnabled && me && me?.platformPrivileges?.managePolicies) || false; | |||
| const showUsersGroups = (isIdentityManagementEnabled && me && me?.platformPrivileges?.manageIdentities) || false; | |||
| const showViews = isViewsEnabled || false; | |||
| const showOwnershipTypes = me && me?.platformPrivileges?.manageOwnershipTypes; | |||
There was a problem hiding this comment.
probably would also want some of these others disabled, but definitely MOST important that home page posts are off. nice work!
chriscollins3456
merged commit ee7930b
into
datahub-project:master
39 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables a few more things if the read only mode is enabled (specifically on the demo site)
Also fixes a styling issue on the manage domains page.
Checklist