Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested domains cypress test #8879

Merged

Conversation

kkorchak
Copy link
Collaborator

Test steps:

  1. create a new domain without a parent
  2. ensure the new domain has no parent in the navigation sidebar
  3. move a domain from the root level to be under a parent
  4. ensure it is no longer on the sidebar navigator at the top level but shows up under the parent
  5. move a domain from under a parent domain to the root level
  6. delete a domain
  7. ensure the domain is no longer in the sidebar navigator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the smoke_test Contains changes related to smoke tests label Sep 21, 2023
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice I like this test for sure! just going back to what i've said on other PRs, could we rely a little more heavily on test IDs instead of text or where things are located in the dom? i'm just concerned about creating tests that fail unnecessarily in the future

@jjoyce0510 jjoyce0510 merged commit b191abb into datahub-project:master Oct 6, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke_test Contains changes related to smoke tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants