Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): bump acryl-sqlglot #8882

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 21, 2023

Extra changes:

  • a new test case to check that ambiguous columns are skipped
  • some memory usage optimization in lineage generation

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Extra changes:
- a new test case to check that ambiguous columns are skipped
- some memory usage optimization in lineage generation
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 21, 2023
@@ -138,7 +138,7 @@ def get_long_description():
sqlglot_lib = {
# Using an Acryl fork of sqlglot.
# https://github.com/tobymao/sqlglot/compare/main...hsheth2:sqlglot:hsheth?expand=1
"acryl-sqlglot==18.0.2.dev15",
"acryl-sqlglot==18.5.2.dev45",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this built and published from?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Sep 21, 2023
@hsheth2 hsheth2 merged commit 2a0200b into datahub-project:master Sep 21, 2023
58 of 59 checks passed
@hsheth2 hsheth2 deleted the bump-sqlglot branch September 21, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants