refactor(misc): testngJava fix, systemrestli client, cache key fix, e… #8926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lasticsearch index builder refactor
github-actions
bot
added
product
hsheth2
approved these changes
Sep 30, 2023
jjoyce0510
reviewed
Oct 3, 2023
| handleDeleteChangeEvent(event); | ||
| } | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
curious what was the IO exception we were looking at?
jjoyce0510
reviewed
Oct 3, 2023
| UpdateIndicesService updateIndicesService = new UpdateIndicesService(graphService, entitySearchService, timeseriesAspectService, | ||
| systemMetadataService, entityRegistry, searchDocumentTransformer, entityIndexBuilders); | ||
|
|
||
| if ("restli".equals(entityClientImpl)) { |
There was a problem hiding this comment.
should this be a const?
jjoyce0510
reviewed
Oct 3, 2023
| @@ -297,4 +298,11 @@ Pair<Boolean, List<Pair<String, RecordTemplate>>> generateDefaultAspectsOnFirstW | |||
| */ | |||
| @Nonnull | |||
| BrowsePathsV2 buildDefaultBrowsePathV2(final @Nonnull Urn urn, boolean useContainerPaths) throws URISyntaxException; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
This does not seem good.
Entity Client should wrap entity service....
I don't quite understand why this is happening here
There was a problem hiding this comment.
I think this is just a lack of understanding for what's happening inside of entity service
yoonhyejin
added
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lasticsearch index builder refactor
Checklist