Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): make quickstart docker compose up command more robust #8929

Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix(cli): make quickstart docker compose up command more robust #8929

merged 2 commits into from
Oct 4, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 2, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 2, 2023
@hsheth2 hsheth2 requested a review from asikowitz October 2, 2023 19:59
@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 8:55pm

@shirshanka shirshanka added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 3, 2023
shirshanka
shirshanka approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI seems unhappy though.

@hsheth2
Copy link
Collaborator Author

hsheth2 commented Oct 4, 2023

The CI issue is related to #8938, so merging through that failure.

@hsheth2 hsheth2 merged commit 419b8a7 into datahub-project:master Oct 4, 2023
57 of 59 checks passed
@hsheth2 hsheth2 deleted the docker-quickstart-kill branch October 4, 2023 03:20
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@asikowitz asikowitz Awaiting requested review from asikowitz

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @shirshanka @maggiehays