feat(chrom-ext-editable): set readOnly to false so that side navigati… #8930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on items are editable
Comment on lines
+85
to
+93
| <SidebarAboutSection readOnly={readOnly} /> | ||
| <StyledDivider /> | ||
| <SidebarOwnerSection readOnly /> | ||
| <SidebarOwnerSection readOnly={readOnly} /> | ||
| <StyledDivider /> | ||
| <SidebarTagsSection readOnly properties={{ hasTags: true, hasTerms: true }} /> | ||
| <SidebarTagsSection readOnly={readOnly} properties={{ hasTags: true, hasTerms: true }} /> | ||
| <StyledDivider /> | ||
| <SidebarDomainSection readOnly /> | ||
| <SidebarDomainSection readOnly={readOnly} /> | ||
| <StyledDivider /> | ||
| <DataProductSection readOnly /> | ||
| <DataProductSection readOnly={readOnly} /> |
There was a problem hiding this comment.
an even simpler approach here could be just to remove the prop readOnly entirely! since it's an optional property and only takes readOnly actions if you pass in a true value
There was a problem hiding this comment.
Hey @chriscollins3456, thought of removing the readOnly entirely too. Writing it this way makes it clear to the reader our intention and easier to switch back if we need to. Say the word and I will remove these lines.
There was a problem hiding this comment.
yeah that's fair enough - let's go with your way I'm always pro for more clarity!
chriscollins3456
approved these changes
Oct 3, 2023
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on items are editable
Description
In this PR, the embedded view used by the Chrome extension is made editable by setting the
readOnly=falseproperty to false. The web-react app embedded view can be accessed via the URL:http://localhost:3000/embed/dataset/urn:li:dataset:(urn:li:dataPlatform:hive,SampleHiveDataset,PROD)/Schema?is_lineage_mode=false&schemaFilter=Editable sections:
Checklist