Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ingest/unity): Add Unity Catalog memory performance testing #8932

Merged
merged 2 commits into from
Oct 4, 2023
Merged

test(ingest/unity): Add Unity Catalog memory performance testing #8932

merged 2 commits into from
Oct 4, 2023

Conversation

asikowitz
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:29am

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 3, 2023
hsheth2
hsheth2 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments but overall looks reasonable

metadata-ingestion/tests/performance/databricks/test_unity.py Outdated

import humanfriendly
import psutil
from performance.databricks.unity_proxy_mock import UnityCatalogApiProxyMock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these imports should be tests.performance...

metadata-ingestion/tests/performance/databricks/test_unity.py Outdated
print(source.report.aspects)


def workunit_sink(workunits: Iterable[MetadataWorkUnit]) -> Tuple[int, int]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like copied code - any chance we could refactor some of the common logic out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@asikowitz asikowitz added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 4, 2023
@asikowitz
Copy link
Collaborator Author

Merging through unrelated smoke test flake

@asikowitz asikowitz merged commit 301d3e6 into datahub-project:master Oct 4, 2023
57 of 58 checks passed
@asikowitz asikowitz deleted the unity-memory-testing branch October 4, 2023 14:23
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@treff7es treff7es Awaiting requested review from treff7es

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asikowitz @hsheth2 @maggiehays