feat(ingest): incremental lineage source helper #8941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
reviewed
Oct 5, 2023
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
…emental-lineage-source-helper' into master+ing-358-incremental-lineage-source-helper
…emental-lineage-source-helper' into master+ing-358-incremental-lineage-source-helper
hsheth2
approved these changes
Oct 9, 2023
| @@ -366,3 +377,128 @@ def _prepend_platform_instance( | |||
| return [BrowsePathEntryClass(id=urn, urn=urn)] + entries | |||
|
|
|||
| return entries | |||
|
|
|||
|
|
|||
| def auto_incremental_lineage( | |||
There was a problem hiding this comment.
this file is getting large - we should consider splitting it up in a follow up PR
| def auto_incremental_lineage( | ||
| graph: Optional[DataHubGraph], | ||
| incremental_lineage: bool, | ||
| include_column_level_lineage: bool, |
There was a problem hiding this comment.
this is kinda confusingly named - maybe we should call it "source_produces_column_lineage" or something
the other possibility is that we mix the two - if the UpstreamLineageClass has fineGrainedLineage, then we use read-modify-write, otherwise we do patch. we'd need to test that patch doesn't delete fineGrainedLineage if it was previously present
Anyways - not a blocker for this PR, but I do want to revisit this
There was a problem hiding this comment.
All the comments are addressed in #8976
asikowitz
pushed a commit
to asikowitz/datahub
that referenced
this pull request
Oct 10, 2023
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist