Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/looker): stop emitting tag owner #8942

Merged
merged 7 commits into from
Oct 12, 2023

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Oct 4, 2023

This is removing the datahub owner for the Measure, Dimension and Temporal tags emitted by Looker and LookML source connectors.

Looker connector is too much opinionated on the ownership of these tags and not aligned with how other connectors work, which just emit the tag with no owner.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs labels Oct 4, 2023
@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Oct 4, 2023
@sgomezvillamor sgomezvillamor marked this pull request as ready for review October 5, 2023 07:58
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 10, 2023

There's a small lint failure, but we'll be able to merge once that's fixed

+ flake8 --count --statistics src/ tests/ examples/
Skipped 1 files
src/datahub/ingestion/source/looker/looker_common.py:78:1: F401 'datahub.metadata.schema_classes.OwnerClass' imported but unused
src/datahub/ingestion/source/looker/looker_common.py:78:1: F401 'datahub.metadata.schema_classes.OwnershipClass' imported but unused
src/datahub/ingestion/source/looker/looker_common.py:78:1: F401 'datahub.metadata.schema_classes.OwnershipTypeClass' imported but unused
3     F401 'datahub.metadata.schema_classes.OwnerClass' imported but unused
3

> Task :metadata-ingestion:lint FAILED

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 10, 2023
@hsheth2 hsheth2 changed the title fix(looker): removes Tag owner fix(ingest/looker): stop emitting tag owner Oct 10, 2023
@hsheth2 hsheth2 merged commit 245c5c0 into datahub-project:master Oct 12, 2023
54 checks passed
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community docs Issues and Improvements to docs hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants