-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest/looker): stop emitting tag owner #8942
Merged
hsheth2
merged 7 commits into
datahub-project:master
from
sgomezvillamor:fix-looker-tags-owner
Oct 12, 2023
Merged
fix(ingest/looker): stop emitting tag owner #8942
hsheth2
merged 7 commits into
datahub-project:master
from
sgomezvillamor:fix-looker-tags-owner
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
PR or Issue related to the ingestion of metadata
docs
Issues and Improvements to docs
labels
Oct 4, 2023
maggiehays
added
the
community-contribution
PR or Issue raised by member(s) of DataHub Community
label
Oct 4, 2023
hsheth2
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There's a small lint failure, but we'll be able to merge once that's fixed
|
hsheth2
added
the
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
label
Oct 10, 2023
hsheth2
changed the title
fix(looker): removes Tag owner
fix(ingest/looker): stop emitting tag owner
Oct 10, 2023
maggiehays
added
the
hacktoberfest-accepted
Acceptance for hacktoberfest https://hacktoberfest.com/participation/
label
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
docs
Issues and Improvements to docs
hacktoberfest-accepted
Acceptance for hacktoberfest https://hacktoberfest.com/participation/
ingestion
PR or Issue related to the ingestion of metadata
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is removing the
datahub
owner for theMeasure
,Dimension
andTemporal
tags emitted by Looker and LookML source connectors.Looker connector is too much opinionated on the ownership of these tags and not aligned with how other connectors work, which just emit the tag with no owner.
Checklist