Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): Detect field type for use in defining the sort order #8992

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix(search): Detect field type for use in defining the sort order #8992

merged 2 commits into from
Oct 18, 2023

Conversation

iprentic
Copy link
Contributor

In elastic cloud, if the unmapped type does not match with the actual field type, an error is raised with the query
Update the code setting the unmapped type to use the field type

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 11, 2023
@iprentic iprentic added the release-0.12.0 PRs targeted for Release 0.12.0 label Oct 16, 2023
@iprentic iprentic merged commit aae1347 into master Oct 18, 2023
40 of 42 checks passed
@iprentic iprentic deleted the nd--sort-unmapped-type branch October 18, 2023 19:26
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@anshbansal anshbansal Awaiting requested review from anshbansal

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ product PR or Issue related to the DataHub UI/UX release-0.12.0 PRs targeted for Release 0.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iprentic @david-leifker @maggiehays