Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): better handling around sink errors #9003

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 13, 2023

Slack ref: https://datahubspace.slack.com/archives/CUMUWQU66/p1696317869262289?thread_ts=1695824642.165599&cid=CUMUWQU66

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 13, 2023
@hsheth2 hsheth2 requested a review from treff7es October 19, 2023 04:58
except Exception as e:
# In case the sink's error handling is bad, we still want to report the error.
self.sink.report.report_failure(
f"Failed to write record: {e}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can log stack trace? I'm a bit concerned about losing information where the error came.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is mainly a fallback mechanism if the source doesn't catch the error elsewhere - given that the error handling in the kafka sink has also improved, I think it's ok

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 24, 2023
@hsheth2 hsheth2 merged commit 32f5dcb into datahub-project:master Oct 25, 2023
53 of 54 checks passed
@hsheth2 hsheth2 deleted the kafka-sink-errors branch October 25, 2023 20:16
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green. release-0.12.0 PRs targeted for Release 0.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants