Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fixes handling of resources filters in UI #9087

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

skrydal
Copy link
Collaborator

@skrydal skrydal commented Oct 24, 2023

Fixes #9085 in the UI part. Pending changes to the update logic. Additional changes to make repo consistent with the usage of the mentioned fields.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX labels Oct 24, 2023
Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM
Please add a breaking change note on https://github.com/datahub-project/datahub/blob/master/docs/how/updating-datahub.md on how to fix the temporary issue.
The temporary work-around you wrote here is sufficient since this would only affect policies that got written in the past 2 weeks for deployments that are using head as the DataHub version and can't reset databases..
Let's wait on green CI.

@pedro93
Copy link
Collaborator

pedro93 commented Oct 24, 2023

Merging as failing CI is unrelated to PR and getting fixed by #9061

Thank you for this contribution!

@pedro93 pedro93 merged commit 378d84a into datahub-project:master Oct 24, 2023
55 of 56 checks passed
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent policy resource filter enum field
3 participants