Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) Fix filtering logic for everwhere generating OR filters #9116

Conversation

chriscollins3456
Copy link
Collaborator

Wherever we submit orFilters, we're using generateOrFilters which converts out nested filters into the correct format. Unfortunately we were only separating out these nested filters in one function above this one for the main search page (the only place we have nested filters). However we also use this function without using the main function above this to filter out nested vs non-nested filters for scrollAcrossEntities - which means we were getting errors in the incorrect format.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 26, 2023
@david-leifker david-leifker added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 26, 2023
@pedro93 pedro93 merged commit 07a5e4c into datahub-project:master Oct 27, 2023
40 checks passed
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants