Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/sql-server): update queries to use escaped procedure name #9127

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix(ingest/sql-server): update queries to use escaped procedure name #9127

merged 1 commit into from
Oct 27, 2023

Conversation

mayurinehate
Copy link
Collaborator

Closes #8884

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 27, 2023
@hsheth2 hsheth2 merged commit 5166d90 into datahub-project:master Oct 27, 2023
55 checks passed
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
@chenteddybear
Copy link

chenteddybear commented Dec 7, 2023 •
edited
Loading

Hi I'm still getting the parse error:
image

it should be EXEC [aaa_new].dbo.sp_helptext 'aaa_new.dbo.[Leo_Common_Log_GetOperatorList_4.3]' with square bracket around the stored procedure name

@chenteddybear chenteddybear mentioned this pull request Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when parsing stored procedure containing special character in the name - feat(ingest/mssql)
4 participants
@mayurinehate @chenteddybear @hsheth2 @maggiehays