Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/db2): fix handling for table properties #9128

Merged
merged 5 commits into from
Nov 2, 2023
Merged

fix(ingest/db2): fix handling for table properties #9128

merged 5 commits into from
Nov 2, 2023

Conversation

deepgarg-visa
Copy link
Contributor

@deepgarg-visa deepgarg-visa commented Oct 27, 2023 •
edited by hsheth2
Loading

Fixes #8835

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

issue link: #8835

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 27, 2023
@hsheth2 hsheth2 changed the title fix(sqlAlchemySource):failed to ingest IBM Db2 metadata fix(ingest/db2): fix handling for table properties Oct 27, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 27, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 30, 2023

@deepgarg-visa looks like there's some lint issues

@hsheth2 hsheth2 removed the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 31, 2023
@deepgarg-visa deepgarg-visa force-pushed the fix-ibm-db2-ingestion-sqlalchemysource branch from e1532f7 to 1ea2c0e Compare October 31, 2023 06:01
@deepgarg-visa deepgarg-visa force-pushed the fix-ibm-db2-ingestion-sqlalchemysource branch from 1ea2c0e to 27ccd9c Compare October 31, 2023 06:11
@deepgarg-visa
Copy link
Contributor Author

@deepgarg-visa looks like there's some lint issues

@hsheth2 resolved the lint issues. kindly review

@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Nov 1, 2023
@deepgarg-visa
Copy link
Contributor Author

@hsheth2
two integration tests are failing which seems to be unrelated
one is related to mssql ingestion and another one is related to vertica ingestion

@hsheth2 hsheth2 merged commit f7cd802 into datahub-project:master Nov 2, 2023
51 checks passed
@deepgarg-visa deepgarg-visa deleted the fix-ibm-db2-ingestion-sqlalchemysource branch November 2, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to ingest IBM Db2 metadata using SQLAlchemy source
3 participants
@deepgarg-visa @hsheth2 @maggiehays