Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): handle exceptions in min, max, mean profiling #9129

Merged

Conversation

mayurinehate
Copy link
Collaborator

Before - failure to compute min, max or median resulted in failure to profile entire table.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 27, 2023
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code seems reasonable (although not a huge fan of the repetitiveness)

in what cases is it not possible to compute the min/max/mean/etc - can we prevent the call using a check on the column's data type?

With the sqlalchemy query combiner, an issue with any part of the query forces it to fallback to a sequence of uncombined/unoptimized queries, instead of fetching everything with a single query - so it's better to avoid the call than catch the exception

@mayurinehate
Copy link
Collaborator Author

in what cases is it not possible to compute the min/max/mean/etc - can we prevent the call using a check on the column's data type?

For snowflake TIME columns => ProfilerDataType.DATETIME
Max query works correctly but during serialization GE throws exception TypeError: 12:30:00 is of type time which cannot be serialized.

@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Nov 1, 2023
@hsheth2 hsheth2 merged commit 95d9ff2 into datahub-project:master Nov 1, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants