Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(java-sdk-dataset): add dataset via java sdk example #9136

Merged
merged 6 commits into from
Nov 9, 2023
Merged

docs(java-sdk-dataset): add dataset via java sdk example #9136

merged 6 commits into from
Nov 9, 2023

Conversation

sachinsaju
Copy link
Contributor

This PR adds an example on how to add a dataset in datahub via datahub java sdk.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs labels Oct 29, 2023
@yoonhyejin yoonhyejin self-requested a review October 31, 2023 03:01
@yoonhyejin
Copy link
Collaborator

LGTM!

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 31, 2023
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 31, 2023 •
edited
Loading

@sachinsaju looks like there's a lint issue on your sample code

[ant:checkstyle] [WARN] /home/runner/work/datahub/datahub/metadata-integration/java/examples/src/main/java/io/datahubproject/examples/DatasetAdd.java:8: Using the '.*' form of import should be avoided - com.linkedin.schema.*. [AvoidStarImport]

@sachinsaju
Copy link
Contributor Author

@hsheth2 I have updated the PR with fix for the lint issues.There is a failed check in smoke test though.Not sure on why the test failed.

@hsheth2 hsheth2 merged commit 5911a7b into datahub-project:master Nov 9, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoonhyejin yoonhyejin yoonhyejin approved these changes

@hsheth2 hsheth2 Awaiting requested review from hsheth2

Assignees
No one assigned
Labels
docs Issues and Improvements to docs hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sachinsaju @yoonhyejin @hsheth2 @maggiehays